Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(console): refine tag related pages #2599

Merged
merged 1 commit into from
Aug 9, 2023
Merged

chore(console): refine tag related pages #2599

merged 1 commit into from
Aug 9, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Aug 7, 2023 •
edited
Loading

Description

Related to #2598

2023-08-07_15-20
2023-08-07_15-20_1
2023-08-07_15-20_2

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft August 7, 2023 07:24
@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #2599 (b639bd9) into main (a131af6) will decrease coverage by 2.85%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2599      +/-   ##
============================================
- Coverage     82.60%   79.76%   -2.85%     
============================================
  Files           456        1     -455     
  Lines         24890       84   -24806     
  Branches       1509       14    -1495     
============================================
- Hits          20560       67   -20493     
+ Misses         3663       17    -3646     
+ Partials        667        0     -667
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 455 files with indirect coverage changes

@jialeicui jialeicui marked this pull request as ready for review August 7, 2023 07:42
@jialeicui jialeicui added chore 🛎️ some tiny change console 🎨 console labels Aug 7, 2023
@jialeicui jialeicui requested a review from waynelwz August 7, 2023 07:42
waynelwz
waynelwz approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynelwz waynelwz merged commit daf2ee7 into star-whale:main Aug 9, 2023
17 checks passed
@jialeicui jialeicui deleted the refine-tag branch August 9, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynelwz waynelwz waynelwz approved these changes

Assignees
No one assigned
Labels
chore 🛎️ some tiny change console 🎨 console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @waynelwz